Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve controller manager logs #4115

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Commits on Nov 17, 2022

  1. Improve controller manager logs

    This now makes use of the tooling provided by upstream
    controller-runtime and component-base/logs. As a consequence, the
    manager now takes a standard set of flags to configure logging.
    
    The default logging format is configured to json, it's the direction
    upstream is going duwe to its tooling support. For tilt, using text
    for now until we provide better tooling to analyze the logs.
    
    Instead of injecting a logger in the reconciler on construction, we now
    use contextual logging. The benefit here is controller-runtime will
    inject a default set of values that uniquely identify the reconcile
    request.
    g-gaston committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    721b5fc View commit details
    Browse the repository at this point in the history