Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.26 E2E tests for Tinkerbell #8757

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 13, 2024

Issue #, if available:
#2399

Description of changes:
Remove kubernetes v1.26 E2E tests for Tinkerbell provider

Testing (if applicable):
make build-all-test-binaries
make lint

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (5703b82) to head (71616c3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8757      +/-   ##
==========================================
- Coverage   73.58%   73.57%   -0.01%     
==========================================
  Files         578      578              
  Lines       36629    36629              
==========================================
- Hits        26953    26951       -2     
- Misses       7950     7951       +1     
- Partials     1726     1727       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Sep 13, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rahulbabu95
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit deba3d8 into aws:main Sep 14, 2024
13 checks passed
@sp1999 sp1999 deleted the remove-1.26-tinkerbell-e2e-tests branch September 14, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants