[aws-cloudwatch-metrics] Updated cw agent image to version 1.247350.0b251780 and introduced bottlerocket support #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b251780 and introduced bottlerocket support
|
@jaypipes |
jaypipes
suggested changes
Apr 4, 2022
| @@ -69,6 +72,14 @@ spec: | |||
| - name: varlibdocker | |||
| hostPath: | |||
| path: /var/lib/docker | |||
| - name: containerdsock | |||
| hostPath: | |||
| {{- if .Values.bottlerocket }} | |||
There was a problem hiding this comment.
I agree that this would solve the immediate problem at hand. However, this value name of bottlerocket is a one-way door for a couple reasons:
- What happens if Bottlerocket decides to change their containerd sock path again?
- What happens if there is another host OS we want to target in the future that has a different sock path?
For this reason, I think it would be better to have a containerdSockPath value name and make it a string, defaulted to /run/containerd/containerd.sock with a comment informing the user to set this to /run/dockershim.sock when using Bottlerrocket as a host OS.
There was a problem hiding this comment.
bottlerocket rejoined the fold in 1.23 and is planning to backport
jaypipes
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description of changes
The purpose of this PR is mainly to align the chart with the latest version of the aws samples manifest as well as providing bottlrocket support.
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
The chart rendering has been tested locally, also it has been installed against an EKS cluster to make sure
ContainerInsightsis working as expected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.