Sets base image builds to push to private ecr #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markapruett
approved these changes
Dec 21, 2022
|
Awaiting ecr creation before this PR is merged. |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This changes the distro-base images to push the the private ecr repos instead directly to public during postsubmits and periodics. These private ecr repos are still open to the world (any logged in aws user) for reading, but to ensure we have a check point before updating the tags in public ecr, specifically the "latest" tags, which people may be relying on, we want to push to private first.
The
eks-distro-base-tag-files-update-postsubmitjob will now use skopeo to mirror the images based on the tags in the EKS_DISTRO_TAG_FILE.yaml to the public ecr repos before opening the PRs in the other repos bumping their respective tag files./hold
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.