Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.8.4.0 (

#155)

* Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.8.4.0

Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.3.1 to 4.8.4.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.8.3.1...spotbugs-maven-plugin-4.8.4.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fixing SING_SINGLETON_GETTER_NOT_SYNCHRONIZED error

* Fixing SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR error

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rishi Baldawa <baldawar@amazon.com>

pom.xml

@@ -40,7 +40,7 @@
     <gpg.plugin.version>3.2.4</gpg.plugin.version>
     <staging.plugin.version>1.6.13</staging.plugin.version>
     <checkstyle.plugin.version>3.3.1</checkstyle.plugin.version>
-    <spotbugs.plugin.version>4.8.3.1</spotbugs.plugin.version>
+    <spotbugs.plugin.version>4.8.4.0</spotbugs.plugin.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
 

src/main/software/amazon/event/ruler/input/DefaultParser.java

@@ -44,22 +44,27 @@ public class DefaultParser implements MatchTypeParser, ByteParser {
     private final SuffixParser suffixParser;
     private final SuffixEqualsIgnoreCaseParser suffixEqualsIgnoreCaseParser;
 
-    DefaultParser() {
+    private DefaultParser() {
         this(new WildcardParser(), new EqualsIgnoreCaseParser(), new SuffixParser(), new SuffixEqualsIgnoreCaseParser());
     }
 
-    DefaultParser(WildcardParser wildcardParser, EqualsIgnoreCaseParser equalsIgnoreCaseParser, SuffixParser suffixParser,
-                  SuffixEqualsIgnoreCaseParser suffixEqualsIgnoreCaseParser) {
+    private DefaultParser(WildcardParser wildcardParser, EqualsIgnoreCaseParser equalsIgnoreCaseParser,
+                          SuffixParser suffixParser, SuffixEqualsIgnoreCaseParser suffixEqualsIgnoreCaseParser) {
         this.wildcardParser = wildcardParser;
         this.equalsIgnoreCaseParser = equalsIgnoreCaseParser;
         this.suffixParser = suffixParser;
         this.suffixEqualsIgnoreCaseParser = suffixEqualsIgnoreCaseParser;
     }
 
-    public static DefaultParser getParser() {
+    public static synchronized DefaultParser getParser() {
         return SINGLETON;
     }
 
+    static DefaultParser getNonSingletonParserForTesting(WildcardParser wildcardParser, EqualsIgnoreCaseParser equalsIgnoreCaseParser,
+                                          SuffixParser suffixParser, SuffixEqualsIgnoreCaseParser suffixEqualsIgnoreCaseParser) {
+        return new DefaultParser(wildcardParser, equalsIgnoreCaseParser, suffixParser, suffixEqualsIgnoreCaseParser);
+    }
+
     @Override
     public InputCharacter[] parse(final MatchType type, final String value) {
         if (type == WILDCARD || type == ANYTHING_BUT_WILDCARD) {

src/test/software/amazon/event/ruler/input/ParserTest.java

@@ -26,7 +26,7 @@ public void testParseString() {
     @Test
     public void testOtherMatchTypes() {
         final int[] parserInvokedCount = { 0, 0, 0, 0 };
-        DefaultParser parser = new DefaultParser(
+        DefaultParser parser = DefaultParser.getNonSingletonParserForTesting(
             new WildcardParser() {
                 @Override
                 public InputCharacter[] parse(String value) {