Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii-config: .NET Version Suffix should be optional #1037

Closed
eladb opened this issue Nov 20, 2019 · 0 comments · Fixed by #1047
Closed

jsii-config: .NET Version Suffix should be optional #1037

eladb opened this issue Nov 20, 2019 · 0 comments · Fixed by #1047
Assignees
@MrArnoldPalmer
Labels
bug This issue is a bug. in-progress Issue is being actively worked on. p1

Comments

@eladb
Copy link
Contributor

eladb commented Nov 20, 2019

🐛 Bug Report

When trying to not provide a .NET version suffix option, I get the following error.

? .NET Version Suffix - optional suffix that will be appended at the end of the NuGet package's version field, mus
t begin with a "-" (e.g. "-devpreview") () (node:67414) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'length' of undefined
    at InputPrompt.onError (/private/tmp/jsii-config/node_modules/inquirer/lib/prompts/input.js:95:35)
    at SafeSubscriber._next (/private/tmp/jsii-config/node_modules/rxjs/internal/Observable.js:66:21)
    at SafeSubscriber.__tryOrUnsub (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:205:16)
    at SafeSubscriber.next (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:143:22)
    at Subscriber._next (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:89:26)
    at Subscriber.next (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:66:18)
    at TakeUntilSubscriber.Subscriber._next (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:89:26)
    at TakeUntilSubscriber.Subscriber.next (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:66:18)
    at FilterSubscriber._next (/private/tmp/jsii-config/node_modules/rxjs/internal/operators/filter.js:52:30)
    at FilterSubscriber.Subscriber.next (/private/tmp/jsii-config/node_modules/rxjs/internal/Subscriber.js:66:18)
(node:67414) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

Then, if I pass in a value, it contiunes.

General Information

  • JSII Version: 0.20.7
@eladb eladb added the bug This issue is a bug. label Nov 20, 2019
@MrArnoldPalmer MrArnoldPalmer self-assigned this Nov 20, 2019
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Nov 22, 2019
@MrArnoldPalmer
fix: Allow Missing Dotnet Version Suffix
cda224e 
Allows empty or undefined dotnet versionSuffix field. Removes filter
logic from inquirer question prompts to prevent conflicts with
validation functions that result in errors being thrown. This seems like
a [bug in inquirer](SBoudrias/Inquirer.js#862)
when filter returns undefined.

Fix broken links in docs.

fixes aws#1037
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Nov 22, 2019
@MrArnoldPalmer
fix: Allow Missing Dotnet Version Suffix
319d246 
Allows empty or undefined dotnet versionSuffix field. Removes filter
logic from inquirer question prompts to prevent conflicts with
validation functions that result in errors being thrown. This seems like
a [bug in inquirer](SBoudrias/Inquirer.js#862)
when filter returns undefined.

Fix broken links in docs.

fixes aws#1037
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Nov 22, 2019
@MrArnoldPalmer
fix: Allow Missing Dotnet Version Suffix
4429e0b 
Allows empty or undefined dotnet versionSuffix field. Removes filter
logic from inquirer question prompts to prevent conflicts with
validation functions that result in errors being thrown. This seems like
a [bug in inquirer](SBoudrias/Inquirer.js#862)
when filter returns undefined.

Fix broken links in docs.

fixes aws#1037
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Nov 22, 2019
@MrArnoldPalmer
fix: Allow Missing Dotnet Version Suffix
18ee268 
Allows empty or undefined dotnet versionSuffix field. Removes filter
logic from inquirer question prompts to prevent conflicts with
validation functions that result in errors being thrown. This seems like
a [bug in inquirer](SBoudrias/Inquirer.js#862)
when filter returns undefined.

Fix broken links in docs.

fixes aws#1037
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Nov 22, 2019
Merged
@SomayaB SomayaB added the in-progress Issue is being actively worked on. label Nov 22, 2019
MrArnoldPalmer added a commit that referenced this issue Nov 25, 2019
@MrArnoldPalmer
fix: Allow Missing Dotnet Version Suffix (#1047)
fc366d0 
Allows empty or undefined dotnet versionSuffix field. Removes filter
logic from inquirer question prompts to prevent conflicts with
validation functions that result in errors being thrown. This seems like
a [bug in inquirer](SBoudrias/Inquirer.js#862)
when filter returns undefined.

Fix broken links in docs.

fixes #1037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
bug This issue is a bug. in-progress Issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow Missing Dotnet Version Suffix MrArnoldPalmer/jsii
3 participants
@eladb @MrArnoldPalmer @SomayaB