Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: local.go.sum is accidentally published #2509

Closed
1 task done
eladb opened this issue Feb 2, 2021 · 1 comment · Fixed by #2507
Closed
1 task done

go: local.go.sum is accidentally published #2509

eladb opened this issue Feb 2, 2021 · 1 comment · Fixed by #2507
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Milestone
Go Sprint Jan 20 ...

Comments

@eladb
Copy link
Contributor

eladb commented Feb 2, 2021

🐛 Bug Report

Affected Languages

  • golang

General Information

  • JSII Version: 1.18.0
  • Platform:

What is the problem?

The file local.go.sum should not be included in the published directory.
@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2021
@eladb eladb mentioned this issue Feb 2, 2021
Merged
@eladb eladb added this to the Go Sprint Jan 20 - Feb 2 2021 milestone Feb 2, 2021
eladb pushed a commit that referenced this issue Feb 2, 2021
fix(go): major version suffix is missing in module names for >=v2 (#2507
32c0add 
)

According to the [go modules spec], starting from 2.0.0, module names must include
A “major version suffix” (e.g. `/v2`).

[go modules spec]: https://golang.org/ref/mod#major-version-suffixes

Fixes #2506

This commit also fixes #2509 by deleting the `local.go.sum` file from the output.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
Go Sprint Jan 20 - Feb 10 2021
Development

Successfully merging a pull request may close this issue.

fix(go): major version suffix is missing in module names for >=v2 aws/jsii
1 participant
@eladb