Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Generator csproj should target .NET Core and not .NET Standard #714

Closed
assyadh opened this issue Aug 16, 2019 · 0 comments · Fixed by #772
Closed

.NET Generator csproj should target .NET Core and not .NET Standard #714

assyadh opened this issue Aug 16, 2019 · 0 comments · Fixed by #772
Labels
feature-request A feature should be added or improved. language/dotnet Related to .NET bindings (C#, F#, ...) needs-triage This issue or PR still needs to be triaged. p0

Comments

@assyadh
Copy link
Contributor

assyadh commented Aug 16, 2019

We don't want to support the .NET framework use cases.

.NET Generator csproj should target .NET Core and not .NET Standard
@assyadh assyadh added language/dotnet Related to .NET bindings (C#, F#, ...) feature-request A feature should be added or improved. p0 needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2019
@assyadh assyadh mentioned this issue Aug 26, 2019
Merged
@assyadh assyadh added this to the .NET Support milestone Aug 27, 2019
@assyadh assyadh mentioned this issue Sep 11, 2019
Merged
RomainMuller pushed a commit that referenced this issue Sep 18, 2019
@RomainMuller
fix(dotnet): fix deep type conversion across the process boundary, in…
ecf8d3b 
…telisense docs, set target to netcoreapp2.1 (#772)

This PR fixes various issues due to how we convert collection elements, and how the type reference is passed when converting.


These two issues are similar and are due to nested Arrays of object not being casted properly:
Fixes aws/aws-cdk#3244
Fixes aws/aws-cdk#3672
Added a unit test to cover the case

This issue is due to Maps of Arrays of Anys not being casted properly:
Fixes aws/aws-cdk#3813 
Added a unit test to cover the case

Also added support for xml documentation which is now added to the NuGet packages and should allow intellisense to provide in IDE help:
Fixes #749
Fixes aws/aws-cdk#1846

Migrated the target framework to netcoreapp2.1 instead of netstandard2.0:
Fixes #714
@McDoit McDoit mentioned this issue Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. language/dotnet Related to .NET bindings (C#, F#, ...) needs-triage This issue or PR still needs to be triaged. p0
Projects
None yet
Milestone
No milestone
1 participant
@assyadh