fix(go): embedded bases may conflict with member names #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we generate proxy structs in Go (for classes or interfaces), we embed the base types (base class or interfaces) in the struct. If the base type has a name that is the same as a member of the hosting type, there will be a conflict. To solve this, we create a unique type alias for each base interface we want to embed. Fixes #2702
eladb
force-pushed
the
fix-field-method-conflict
branch
from
c14d3f3
to
4ffac8b
Compare
eladb
changed the title
MrArnoldPalmer
previously requested changes
Mar 15, 2021
|
@MrArnoldPalmer I am seeing some runtime errors, so this needs a bit more work. |
RomainMuller
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generate proxy structs in Go (for classes or interfaces), we embed the base types (base class or interfaces) in the struct. If the base type has a name that is the same as a member of the hosting type, there will be a conflict.
To solve this, we create a unique type alias for each base interface we want to embed.
Fixes #2702
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.