Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): Correctly return instances of un-exported types #321

Merged
merged 2 commits into from
Nov 26, 2018
Merged

fix(kernel): Correctly return instances of un-exported types #321

merged 2 commits into from
Nov 26, 2018

Commits on Nov 26, 2018

  1. chore: Add compliance test around #320 

    This test covers the behavior of the JSII runtimes when a method is
declared to return an interface type, and returns an instance of a
private (un-exported) type that implements the interface while extending
an exported type. This has been seen to cause issues in the Java
runtime, for example, as the JSII kernel will return an ObjID with a
type fragment that refers to the exported super-class, and not the
interface type.
    @RomainMuller
    RomainMuller committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    151af56 View commit details
    Browse the repository at this point in the history

  2. fix(kernel): Correctly return instances of un-exported types 

    When an un-exported type that extends an exported type is returned with
an interface as the declared type, the JSII kernel used to return a ref
with the FQN of the exported supertype, instead of correctly wrapping
the instance in a proxy of the interface type as it should have.

Fixes #302
    @RomainMuller
    RomainMuller committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    fb46f02 View commit details
    Browse the repository at this point in the history