-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Ruby support #326
[WIP] Ruby support #326
Conversation
Includes: - Module definitions with some attributes such as name, version and tarball path - Basic directory structure - gemspec Gems are building and integrated with tests
Round-trip objrefs
Needed to add class hierarchy
Invoke methods
Required dynamic creation of objects
- Enum support - Method result
deserialize method output
- idiomatic toString
datatype.to_jsii
Initial support for async callbacks
Almost fully implement overrides
@eladb Are you still working on this branch? I'd be willing to contribute to the Ruby implementation, but I'm struggling to get a development environment setup so I can run the relevant tests. Do you have any advice? |
@floehopper I've been working on this on the back burner, and would love contributions! Ideally our contribution guide should explain how to setup an environment, but it might be outdated. What are the specific issues you are running into? |
@eladb Thanks for the encouragement. Since my setup woes are orthogonal to this PR, I've created a new issue to ask for help. |
Yeah, I'd be up for that. Although I think I'd like to dig into the code a little bit first just to orient myself and make any chat as useful as possible. Also I should mention that my experience is more in the Ruby end of things than the TypeScript end! |
@floehopper no worries. hit me up here or on Gitter and we'll set up some time |
1315be5
to
8552b7a
Compare
I'm going to close this PR until we have room to pick it up again. Feel free to reopen if someone thinks this was closed in error. |
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
This is a WIP pull request for jsii Ruby support.
Compliance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.