-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make jsii
fully synchronous
#3467
Merged
Merged
Commits on Apr 1, 2022
-
chore: make
jsii
fully synchronousWith a sample set of 1, I have detemined that there is about 30% tax caused by asynchronous functions in the compiler. The `typescript` compiler itself is fully synchronous, and we basically moved to do the same, and this turns out reducing the amount of time wasted in the runloop and in promise bookeeping. Tested on `aws-cdk-lib`, it turns out to be reducing the compile time from ~142 seconds to ~100 seconds.
Configuration menu - View commit details
-
Copy full SHA for 6eab08f - Browse repository at this point
Copy the full SHA 6eab08fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76695af - Browse repository at this point
Copy the full SHA 76695afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10db505 - Browse repository at this point
Copy the full SHA 10db505View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cb1c0d - Browse repository at this point
Copy the full SHA 2cb1c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64d398c - Browse repository at this point
Copy the full SHA 64d398cView commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for de939c5 - Browse repository at this point
Copy the full SHA de939c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07d680e - Browse repository at this point
Copy the full SHA 07d680eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b06f91 - Browse repository at this point
Copy the full SHA 3b06f91View commit details -
Configuration menu - View commit details
-
Copy full SHA for adb5af6 - Browse repository at this point
Copy the full SHA adb5af6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.