Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy non-hidden bases when erasing hidden interfaces #392

Merged
merged 4 commits into from
Mar 19, 2019
Merged

fix: copy non-hidden bases when erasing hidden interfaces #392

merged 4 commits into from
Mar 19, 2019

Commits on Mar 19, 2019

  1. fix: copy non-hidden bases when erasing hidden interfaces 

    When a type inherits (extends/implements) from a hidden (private/internal)
interface, and that interface extends a non-hidden interface, we need to 
copy the non-hidden interface to the consuming type so that it can be polymorphically
used.

Follow up on #390

Co-authored-by: RomainMuller <rmuller@amazon.com>
    @RomainMuller
    Elad Ben-Israel and RomainMuller committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    8c3fe91 View commit details
    Browse the repository at this point in the history

  2. update pacmak test expectations

    Elad Ben-Israel committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    b9de660 View commit details
    Browse the repository at this point in the history

  3. fix typo in error message

    Elad Ben-Israel committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    f4d1b1a View commit details
    Browse the repository at this point in the history

  4. update jsii-reflect tests

    Elad Ben-Israel committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    8404cc1 View commit details
    Browse the repository at this point in the history