fix: type annotation for callable metaclass #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
sirrus233
changed the title
RomainMuller
previously approved these changes
Jul 18, 2023
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
RomainMuller
previously approved these changes
Jul 18, 2023
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
RomainMuller
previously approved these changes
Jul 18, 2023
|
Well turns out |
# Conflicts: # .all-contributorsrc
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update to pyright has surfaced a typing bug in JSII which means (in practice) that constructs in AWS CDK are no longer statically typed when using pyright. That includes most users of VSCode.
Further details in #4118 and the linked context issue.
The fix is pretty simple. Since it's just a type annotation, not much to test. But I did build the package and confirmed that static typing is fixed after the change here is picked up.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.