Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): Set this in static contexts #460

Merged
merged 2 commits into from
Apr 16, 2019
Merged

fix(kernel): Set this in static contexts #460

merged 2 commits into from
Apr 16, 2019

Commits on Apr 16, 2019

  1. fix(kernel): Set this in static contexts 

    Javascript allows static members to refer to other static members
through `this`, but the `jsii-kernel` passed `null` for the `this`
context in `sinvoke`, making it impossible to invoke static methods that
made use of this feature through the `jsii` runtimes.

Fixes aws/aws-cdk#2304
    @RomainMuller
    RomainMuller committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    d4a2bd3 View commit details
    Browse the repository at this point in the history

  2. Add missing test expectation fixes.

    @RomainMuller
    RomainMuller committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    e573660 View commit details
    Browse the repository at this point in the history