Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): improve property override detection #692

Merged
merged 7 commits into from
Aug 10, 2019

Commits on Aug 9, 2019

  1. fix(java): improve property override detection

    The previous code only checked whether a methodd name was a get/setter
    by checking if it's name started by `get` or `set` and was at least 4
    characters long. This is insufficient, as a method called `settings`
    would be misidentified.
    
    Changed to expect getters to have zero parameters, and setters to have
    exactly one parameter and to match a corresponding getter.
    RomainMuller committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    64b6e7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f1e06d View commit details
    Browse the repository at this point in the history
  3. PR feedback

    RomainMuller committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    4d5896d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e88eefb View commit details
    Browse the repository at this point in the history
  5. check-in changed file

    RomainMuller committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    1b92019 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f6044d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. Configuration menu
    Copy the full SHA
    7e2d4bb View commit details
    Browse the repository at this point in the history