Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric karpenter_interruption_received_messages includes non-karpenter instance events #6376

Open
shailendher opened this issue Jun 18, 2024 · 1 comment · May be fixed by #6386
Open

Metric karpenter_interruption_received_messages includes non-karpenter instance events #6376

shailendher opened this issue Jun 18, 2024 · 1 comment · May be fixed by #6386
Labels
documentation Improvements or additions to documentation needs-triage Issues that need to be triaged

Comments

@shailendher
Copy link

Description

How can the docs be improved?

I was quite surprised the first time when the metric karpenter_interruption_received_messages{message_type="SpotInterruptionKind"} didn't match karpenter_nodeclaims_terminated{reason="interruption"}.

Looking through the eventbridge configuration, it's quite clear why the karpenter_interruption_received_messages metric is aggregated at the account level. Perhaps the documentation could be updated to make it clear?

karpenter-provider-aws/website/content/en/docs/reference/metrics.md

Lines 101 to 102 in e326781

### `karpenter_interruption_received_messages`
Count of messages received from the SQS queue. Broken down by message type and whether the message was actionable.

Alternative would be to filter out non-Karpenter-related events from the karpenter_interruption_received_messages metric.
@shailendher shailendher added documentation Improvements or additions to documentation needs-triage Issues that need to be triaged labels Jun 18, 2024
@kantanakamura
Copy link

I'd like to work on this issue. Could you please assign it to me?

@kantanakamura kantanakamura linked a pull request Jun 19, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation needs-triage Issues that need to be triaged
Projects
None yet
Milestone
No milestone
2 participants
@shailendher @kantanakamura