Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix website for adding capture information of karpenter metric #6386

Closed
wants to merge 1 commit into from

Conversation

kantajp
Copy link

@kantajp kantajp commented Jun 19, 2024

Fixes #6376 6376
Description
The description of karpenter_interruption_received_messages was missing, so I added the capture information in this PR.
How was this change tested?
make website

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kantajp kantajp requested a review from a team as a code owner June 19, 2024 11:10
@kantajp kantajp requested a review from ljosyula June 19, 2024 11:10
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 972c4bb
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6672bc8f5e61a000085ebe5f
😎 Deploy Preview https://deploy-preview-6386--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kantajp kantajp changed the title docs: fix website for add caputure docs: fix website for adding capture information of karpenter metric Jun 19, 2024
Count of messages received from the SQS queue. Broken down by message type and whether the message was actionable.

**Note**: The `karpenter_interruption_received_messages` metric is aggregated at the account level. Therefore, it may include messages that are not directly related to Karpenter. If you notice a discrepancy between this metric and the `karpenter_nodeclaims_terminated{reason="interruption"}` metric, it could be due to the inclusion of non-Karpenter-related events in the `karpenter_interruption_received_messages` metric. To ensure accurate tracking, consider filtering out non-Karpenter-related events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated, so if you want to add custom text to this file, we are going to have to make changes to the metrics_gen_docs.go script that is responsible for generating all of this info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a separate note (since I'm assuming you are making this note because you were trying to make an alert based off of this metric), is there a way that you think that we could make this metric more helpful for monitoring?

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric karpenter_interruption_received_messages includes non-karpenter instance events
2 participants