New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: RFC Supporting ODCR in Karpenter #5716

Merged

jonathan-innis merged 43 commits into aws:main from garvinp-stripe:garvinp-odcr-support-doc

Sep 6, 2024

Contributor

garvinp-stripe commented Feb 23, 2024 •

edited

Loading

Starts the fix but doesn't completely fixes #3042

Description
Narrowly scoped design doc for support ODCR in Karpenter.

How was this change tested?

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify bot commented Feb 23, 2024 •

edited

Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`6760e96`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/65d7e03e3d1e3f00089b777d

netlify bot commented Feb 23, 2024 •

edited

Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`84174d0`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66db49c3b898dd00089099fb

garvinp-stripe marked this pull request as ready for review

February 23, 2024 21:21

garvinp-stripe requested a review from a team as a code owner

February 23, 2024 21:21

garvinp-stripe requested a review from jigisha620

February 23, 2024 21:21

jonathan-innis reviewed

View reviewed changes

Contributor

jonathan-innis left a comment

Nice doc! Some high-level comments

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

coveralls commented Feb 28, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 10743381744

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 83.025%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	91.67%

Totals
Change from base Build 10743355541:	-0.02%
Covered Lines:	5512
Relevant Lines:	6639

💛 - Coveralls

billrayburn requested a review from akestner

March 12, 2024 17:40

Contributor Author

garvinp-stripe commented Mar 25, 2024

Sorry for the slow down. I will try to get back to this PR but atm I got reshuffled in work so need some time to get back to this

jonathan-innis self-assigned this

tvonhacht-apple reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

tvonhacht-apple reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

tvonhacht-apple reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

jonathan-innis reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

This was referenced May 14, 2024

feat: RFC Implementation Supporting ODCR #6198

Open

feat: RFC Implementation Supporting AWS On-Demand Capacity Reservations kubernetes-sigs/karpenter#1263

Closed

bryantbiggs reviewed

View reviewed changes

designs/odcr.md Show resolved Hide resolved

bryantbiggs reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

bryantbiggs reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

eptiger reviewed

View reviewed changes

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

njtran reviewed

View reviewed changes

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Jun 26, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

github-actions bot added lifecycle/stale and removed lifecycle/stale labels

jonathan-innis reviewed

View reviewed changes

designs/odcr.md Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

designs/odcr.md Outdated Show resolved Hide resolved

jonathan-innis force-pushed the garvinp-odcr-support-doc branch 5 times, most recently from e252c95 to 36f9a83 Compare

July 9, 2024 07:52

tvonhacht-apple and others added 26 commits

September 6, 2024 11:28


          add odcr information from current poc implementation

b5c9de3


          fix typos and clunky sentences

b3e1708


          Adresse RFC comments

b9e2d6a


          Add support of open and targeted ODCRs

319b871


          Update docs to not use capacity-type capacity-reservation

14b9531


          Update Goals/Non-Goals

5ca00ca


          Drop some fields from status API

5ec34d6


          Add NodePool selection options section

10ae3b4


          Add scheduling representation sections

afee12f


          Add additional comments about consolidating between ODCRs

06be8d6


          Reoranizing sections

27b605d


          Add drift section

dd6d3c7


          Update example offerings

4cb37cf


          Add note about performance benchmarking

20cf260


          Final review, last open questions is appendix, text for odcr first sc…

5e4e21a

…heduling and what label to use


          Update RFC with closed api decision

99debfa


          Add note on mutual exclusivity of fields


          Edits after maintainer review

163e6c3


          Add section on open ODCRs

a0cad76


          Add section on prioritizing ODCRs during scheduling

be1c6c5


          Update ToC

d43fc38


          Add CreateFleet appendix examples

7bc0614


          Convert some outputs to table

3a7841b


          Combine some rows in the appendix

73a8efb


          PR comments

0579fdb


          Add a note on prioritizing reserved

84174d0

jonathan-innis force-pushed the garvinp-odcr-support-doc branch from e7c03e4 to 84174d0 Compare

September 6, 2024 18:28

jonathan-innis enabled auto-merge (squash)

September 6, 2024 18:28

njtran approved these changes

View reviewed changes

jonathan-innis merged commit bed745b into aws:main

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GnatorX GnatorX left review comments

eptiger eptiger left review comments

bryantbiggs bryantbiggs left review comments

jonathan-innis jonathan-innis left review comments

tvonhacht-apple tvonhacht-apple left review comments

njtran njtran approved these changes

engedaam engedaam left review comments

jigisha620 Awaiting requested review from jigisha620 jigisha620 is a code owner automatically assigned from aws/karpenter

akestner Awaiting requested review from akestner

Labels