Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add AMI requirement note #5904

Merged
merged 1 commit into from
Mar 21, 2024
Merged

docs: add AMI requirement note #5904

merged 1 commit into from
Mar 21, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Mar 20, 2024

Fixes #N/A

Description
Adds a note under amiSelectorTerms which calls out that the only requirement Karpenter can detect is architecture. Gives a specific example for accelerated GPU AMIs since Karpenter can differentiate and select the right AMI when no amiSelectorTerms are provided.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner March 20, 2024 00:18
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ed1a5b6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65fb52a06f22900008ea2f83
😎 Deploy Preview https://deploy-preview-5904--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Mar 20, 2024

Pull Request Test Coverage Report for Build 8366015998

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.458%

Totals Coverage Status
Change from base Build 8363662613: 0.02%
Covered Lines: 5340
Relevant Lines: 6476

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) March 21, 2024 16:41
@jmdeal jmdeal merged commit 43a9ba0 into aws:main Mar 21, 2024
17 checks passed
@jmdeal jmdeal deleted the ami-note branch August 14, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants