Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to select instance by EBS Maximum Bandwidth #5925

Merged
merged 1 commit into from
May 5, 2024

Conversation

NetanelK
Copy link
Contributor

Fixes #5905

Description
This PR adds the ability to select instances by EBS maximum bandwidth limit, by using the label karpenter.k8s.aws/instance-ebs-bandwidth

How was this change tested?
make presubmit, Added EBS Info to codegen.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@NetanelK NetanelK requested a review from a team as a code owner March 25, 2024 20:58
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 8fb1f6c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6637099809af190008947ece
😎 Deploy Preview https://deploy-preview-5925--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me! Just one comment.

hack/code/instancetype_testdata_gen/main.go Outdated Show resolved Hide resolved
@NetanelK NetanelK force-pushed the feature/ebs-bandwidth-selector branch from 3a0d889 to 2eb78f5 Compare April 2, 2024 14:21
@NetanelK NetanelK requested a review from njtran April 2, 2024 14:23
jonathan-innis
jonathan-innis previously approved these changes Apr 2, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, optional. It would just be good to know if this is a consistent value that we can rely-on, and, if so, where is the constant that we can point to for it?

pkg/providers/instancetype/types.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8955652337

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 82.273%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8948039394: 0.03%
Covered Lines: 5407
Relevant Lines: 6572

💛 - Coveralls

@NetanelK NetanelK requested a review from njtran April 3, 2024 10:29
@NetanelK NetanelK force-pushed the feature/ebs-bandwidth-selector branch 2 times, most recently from 61612a3 to 029742a Compare April 4, 2024 09:54
jonathan-innis
jonathan-innis previously approved these changes Apr 8, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-029742a6a108a3a4f249172debaf09d291035c40.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-029742a6a108a3a4f249172debaf09d291035c40" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis
Copy link
Contributor

@NetanelK Looks like it needs a rebase, but otherwise, we should be good to merge here.

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis jonathan-innis force-pushed the feature/ebs-bandwidth-selector branch from 50e4139 to 8fb1f6c Compare May 5, 2024 04:22
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) May 5, 2024 04:25
@jonathan-innis jonathan-innis merged commit b17e0eb into aws:main May 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter instances based on EBS baseline bandwidth
4 participants