Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: make AMISelectorTerms required #5992

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Apr 6, 2024

Fixes #N/A

Description
Makes the AMISelectorTerms required. @jmdeal is taking this over.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner April 6, 2024 00:07
@njtran njtran requested a review from jmdeal April 6, 2024 00:07
Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 54b6f91
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/663411a1b7c5e80008a1fff9
😎 Deploy Preview https://deploy-preview-5992--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8931235087

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 44 of 56 (78.57%) changed or added relevant lines in 4 files are covered.
  • 22 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.005%) to 82.093%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/amifamily/ami.go 14 16 87.5%
pkg/apis/v1beta1/zz_generated.deepcopy.go 5 15 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclass/status/controller.go 3 75.47%
pkg/providers/amifamily/custom.go 3 66.67%
pkg/controllers/nodeclass/hash/controller.go 7 72.13%
pkg/controllers/nodeclaim/tagging/controller.go 9 80.0%
Totals Coverage Status
Change from base Build 8927066959: 0.005%
Covered Lines: 5428
Relevant Lines: 6612

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-f8ad58849a80f76efe220cf6f55fcc171ca5d9f7.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-f8ad58849a80f76efe220cf6f55fcc171ca5d9f7" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jmdeal jmdeal force-pushed the nodeclassbreak branch 9 times, most recently from 547bc61 to a04f4d9 Compare April 25, 2024 17:08
cmd/controller/main.go Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/providers/amifamily/ami.go Outdated Show resolved Hide resolved
pkg/providers/amifamily/ami.go Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
pkg/providers/launchtemplate/suite_test.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass_validation_cel_test.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass_validation_cel_test.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass_validation_webhook_test.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass_validation_webhook_test.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
pkg/providers/amifamily/ami.go Show resolved Hide resolved
website/content/en/preview/concepts/nodeclasses.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclasses.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclasses.md Outdated Show resolved Hide resolved
website/content/en/preview/upgrading/upgrade-guide.md Outdated Show resolved Hide resolved
@jmdeal jmdeal force-pushed the nodeclassbreak branch 5 times, most recently from 6df822e to df294dc Compare May 2, 2024 16:58
@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Unable to make progress due to some dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants