Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify need for credentials when running make codegen #6014

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

lplazas
Copy link
Contributor

@lplazas lplazas commented Apr 10, 2024

docs: Clarify need for credentials when running make codegen

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lplazas lplazas requested a review from a team as a code owner April 10, 2024 11:43
@lplazas lplazas requested a review from tzneal April 10, 2024 11:43
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 374d547
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6617fe64f128de0008b74ac8
😎 Deploy Preview https://deploy-preview-6014--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam
Copy link
Contributor

Can we make this change in all versions of the docs?

@lplazas
Copy link
Contributor Author

lplazas commented Apr 11, 2024

Updated the PR @engedaam

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@engedaam engedaam enabled auto-merge (squash) April 11, 2024 15:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8649105945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.246%

Totals Coverage Status
Change from base Build 8639149830: 0.0%
Covered Lines: 5332
Relevant Lines: 6483

💛 - Coveralls

@engedaam engedaam merged commit 283e7b2 into aws:main Apr 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants