Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add information about consolidateAfter not working with WhenUnderutilized #6016

Merged

Conversation

morremeyer
Copy link
Contributor

Description

This adds documentation about the consolidateAfter configuration for NodePools not being available when consolidationPolicy: WhenUnderutilized is set.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@morremeyer morremeyer requested a review from a team as a code owner April 10, 2024 14:35
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e431f64
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/661961e91f444100083fbd1a
😎 Deploy Preview https://deploy-preview-6016--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis force-pushed the docs/consolidate-after-when-underutilized branch from 8140b19 to e431f64 Compare April 12, 2024 16:31
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 12, 2024 16:31
@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8665165099

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 82.287%

Totals Coverage Status
Change from base Build 8664991124: 0.03%
Covered Lines: 5333
Relevant Lines: 6481

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 9ca7ed8 into aws:main Apr 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants