Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Hydrate Instance Type Data for docs-gen #6067

Merged
merged 1 commit into from
Apr 21, 2024
Merged

chore: Hydrate Instance Type Data for docs-gen #6067

merged 1 commit into from
Apr 21, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Hydrate instance type data for docs-gen

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 20, 2024 01:49
@engedaam engedaam requested a review from jmdeal April 20, 2024 01:49
@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a0c120f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66231f31f2610f0008dfa872

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8761720358

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 81.963%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8761660430: -0.02%
Covered Lines: 5394
Relevant Lines: 6581
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit ff2515a into aws:main Apr 21, 2024
17 checks passed
@engedaam engedaam deleted the fix-docs-gen branch April 21, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis