Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use Security Group Status Controller to Asynchronously Hydrate Security Group Data #6069

Merged
merged 2 commits into from
Apr 25, 2024
Merged

chore: Use Security Group Status Controller to Asynchronously Hydrate Security Group Data #6069

merged 2 commits into from
Apr 25, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Asynchronously hydrate with Security Group data. The controller will attempt to refresh the data every 5 minutes, and implement a exponential backoff for delay: 1ms and max: 1000s

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 21, 2024 03:57
@netlify Netlify
Copy link

netlify bot commented Apr 21, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1e3122c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66248eb38611d80008a17017

@netlify Netlify
Copy link

netlify bot commented Apr 21, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit b777dca
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/662ad6df233c4e0008d98292
😎 Deploy Preview https://deploy-preview-6069--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8840124707

Details

  • 11 of 12 (91.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 82.028%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/launchtemplate/launchtemplate.go 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
pkg/providers/launchtemplate/launchtemplate.go 1 84.08%
Totals Coverage Status
Change from base Build 8839789039: 0.05%
Covered Lines: 5395
Relevant Lines: 6577
💛 - Coveralls

@engedaam engedaam changed the title chore: Add an Security Group Controller to Asynchronously Hydrate Security Group Data chore: Use Security Group Status Controller to Asynchronously Hydrate Security Group Data Apr 23, 2024
engedaam
engedaam commented Apr 23, 2024
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-6276493627a1a1bcc3eb77b20561939aba9d2a57.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-6276493627a1a1bcc3eb77b20561939aba9d2a57" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@engedaam engedaam force-pushed the securitygroup-controller branch 9 times, most recently from 629a3d0 to 85c5289 Compare April 23, 2024 22:33
jonathan-innis
jonathan-innis reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level comment about paring down the provider

pkg/controllers/nodeclass/status/securitygroup.go Outdated Show resolved Hide resolved
pkg/providers/securitygroup/securitygroup.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the securitygroup-controller branch 5 times, most recently from 2cab316 to 140d471 Compare April 24, 2024 19:31
engedaam
engedaam commented Apr 24, 2024
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-140d471264782eb84aa8f999c2b4312531bf5c97.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-140d471264782eb84aa8f999c2b4312531bf5c97" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis
jonathan-innis reviewed Apr 25, 2024
View reviewed changes
pkg/apis/v1beta1/ec2nodeclass_status.go Outdated Show resolved Hide resolved
pkg/cloudprovider/drift.go Outdated Show resolved Hide resolved
pkg/controllers/nodeclass/status/securitygroup.go Outdated Show resolved Hide resolved
pkg/providers/launchtemplate/suite_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the securitygroup-controller branch 5 times, most recently from 8f87d48 to 430df3e Compare April 25, 2024 17:01
@engedaam engedaam force-pushed the securitygroup-controller branch 3 times, most recently from 3cb8c38 to 18e41ec Compare April 25, 2024 17:19
njtran
njtran reviewed Apr 25, 2024
View reviewed changes
pkg/cloudprovider/drift.go Show resolved Hide resolved
pkg/cloudprovider/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/launchtemplate/launchtemplate.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the securitygroup-controller branch 2 times, most recently from 1cab944 to 2efa55d Compare April 25, 2024 18:03
njtran
njtran reviewed Apr 25, 2024
View reviewed changes
pkg/cloudprovider/drift.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the securitygroup-controller branch 4 times, most recently from 876d20f to 0e18c2b Compare April 25, 2024 20:25
njtran
njtran reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

njtran
njtran previously approved these changes Apr 25, 2024
View reviewed changes
@engedaam engedaam enabled auto-merge (squash) April 25, 2024 22:11
@engedaam engedaam merged commit e6fa442 into aws:main Apr 25, 2024
16 checks passed
@engedaam engedaam mentioned this pull request May 11, 2024
Closed
@engedaam engedaam deleted the securitygroup-controller branch July 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@njtran njtran njtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@engedaam @coveralls @njtran @jonathan-innis