Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Always add retention policy to E2E run logs #6104

Merged
merged 1 commit into from
Apr 26, 2024
Merged

ci: Always add retention policy to E2E run logs #6104

merged 1 commit into from
Apr 26, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Always add retention policy to E2E run logs for clean-up

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 26, 2024 16:28
@engedaam engedaam requested a review from njtran April 26, 2024 16:28
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0ae1e6f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/662bd62716ea90000884e135

jmdeal
jmdeal approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) April 26, 2024 16:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8851354249

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.013%
Totals Coverage Status
Change from base Build 8840193498: 0.0%
Covered Lines: 5394
Relevant Lines: 6577
💛 - Coveralls

@engedaam engedaam merged commit 3cb2cf5 into aws:main Apr 26, 2024
17 checks passed
@engedaam engedaam deleted the run_rentation_policy_always branch July 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal