Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Always update log retention #6139

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented May 3, 2024

Fixes #N/A

Description

This ensures that we always update the log retention to 30d, regardless of whether we succeed or fail or cancel the test.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner May 3, 2024 08:15
Copy link

netlify bot commented May 3, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 87cea1a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6634a36660c65b000845b112

@jonathan-innis jonathan-innis force-pushed the remove-unneeded-log-retention branch 2 times, most recently from 41e2e51 to 3bf1ee2 Compare May 3, 2024 08:17
@jonathan-innis jonathan-innis enabled auto-merge (squash) May 3, 2024 08:17
@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 8936413233

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.187%

Totals Coverage Status
Change from base Build 8930965506: 0.0%
Covered Lines: 5403
Relevant Lines: 6574

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the remove-unneeded-log-retention branch from 3bf1ee2 to 87cea1a Compare May 3, 2024 08:42
@jonathan-innis jonathan-innis changed the title ci: Remove unneeded log retention ci: Always update log retention May 3, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit f6f1399 into aws:main May 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants