Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use AMI IDs in the logs for AMI discovery #6220

Merged
merged 1 commit into from
May 20, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description
Fixed the Log message listing all AMIs details

{"level":"DEBUG","time":"2024-05-17T12:58:20.632-0500","logger":"controller.nodeclass.status","message":"discovered amis","ec2nodeclass":"critical-addons-only","ids":[{"Name":"amazon-eks-arm64-node-1.29-v20240514","AmiID":"ami-06882dd1807dd93be","CreationDate":"2024-05-14T16:59:11.000Z","Requirements":{"karpenter.k8s.aws/instance-accelerator-count":{"Key":"karpenter.k8s.aws/instance-accelerator-count","MinValues":null},"karpenter.k8s.aws/instance-gpu-count":{"Key":"karpenter.k8s.aws/instance-gpu-count","MinValues":null},"kubernetes.io/arch":{"Key":"kubernetes.io/arch","MinValues":null}}},{"Name":"amazon-eks-gpu-node-1.29-v20240514","AmiID":"ami-086598116d98d2953","CreationDate":"2024-05-14T16:59:11.000Z","Requirements":{"karpenter.k8s.aws/instance-gpu-count":{"Key":"karpenter.k8s.aws/instance-gpu-count","MinValues":null},"kubernetes.io/arch":{"Key":"kubernetes.io/arch","MinValues":null}}},{"Name":"amazon-eks-gpu-node-1.29-v20240514","AmiID":"ami-086598116d98d2953","CreationDate":"2024-05-14T16:59:11.000Z","Requirements":{"karpenter.k8s.aws/instance-accelerator-count":{"Key":"karpenter.k8s.aws/instance-accelerator-count","MinValues":null},"kubernetes.io/arch":{"Key":"kubernetes.io/arch","MinValues":null}}},{"Name":"amazon-eks-node-1.29-v20240514","AmiID":"ami-0ef5558292b11416e","CreationDate":"2024-05-14T16:59:11.000Z","Requirements":{"karpenter.k8s.aws/instance-accelerator-count":{"Key":"karpenter.k8s.aws/instance-accelerator-count","MinValues":null},"karpenter.k8s.aws/instance-gpu-count":{"Key":"karpenter.k8s.aws/instance-gpu-count","MinValues":null},"kubernetes.io/arch":{"Key":"kubernetes.io/arch","MinValues":null}}}],"count":4}

To just using AMI Ids

{"level":"DEBUG","time":"2024-05-17T11:20:42.176-0700","logger":"controller.nodeclass.status","message":"discovered amis","ec2nodeclass":"default","ids":"ami-06882dd1807dd93be, ami-086598116d98d2953, ami-0ef5558292b11416e","count":4}

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner May 17, 2024 18:21
@engedaam engedaam requested a review from ljosyula May 17, 2024 18:21
Copy link

netlify bot commented May 17, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 63a57e6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/664b92d91e83250008ac37f4

pkg/providers/amifamily/ami.go Outdated Show resolved Hide resolved
pkg/providers/amifamily/ami.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9163109062

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.47%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 9160162534: -0.01%
Covered Lines: 5495
Relevant Lines: 6663

💛 - Coveralls

@engedaam engedaam force-pushed the fix-status-ami-message branch 2 times, most recently from 1f84f13 to 86e5c10 Compare May 17, 2024 18:55
@engedaam engedaam force-pushed the fix-status-ami-message branch 2 times, most recently from cd1df87 to da11aa6 Compare May 17, 2024 19:09
jonathan-innis
jonathan-innis previously approved these changes May 17, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) May 20, 2024 18:14
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 94bedac into aws:main May 20, 2024
17 checks passed
@engedaam engedaam deleted the fix-status-ami-message branch May 20, 2024 18:21
engedaam added a commit to engedaam/karpenter that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants