-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Drop logger name injection and add consistent formatting for K8s objects #6255
BREAKING: Drop logger name injection and add consistent formatting for K8s objects #6255
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
97afc5c
to
eb558a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
Pull Request Test Coverage Report for Build 9197543833Details
💛 - Coveralls |
eb558a0
to
507b1c2
Compare
1169b7a
to
35f931a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
Drop logger name injection at the top of controllers and add consistent formatting for K8s objects
Before PR
After PR
Looking at the difference between these two log lines, you can see that we no longer have duplicate keys for
nodeclaim
and we changed our naming mechanism for the logger name.How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.