-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new pod identity based tags #6319
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 9432373714Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9432510660Details
💛 - Coveralls |
Do we consider this breaking or an implementation detail? |
I think this is an implementation detail. I tested this by creating a deployment with one replica with the old annotation, waiting for a node to come online, upgrading karpenter to an image with the new annotation, scaling out the deployment to two replicas after the upgrade, and then waiting for the second node to come up. Both nodes continued to operate just fine and later when a All of that to say, I don't think a cx would take a dependency on presence/absence of tags on an instance when those instances could be rotated out at any time or when karpenter manages those instances in the first place. |
@@ -271,7 +271,11 @@ func (p *DefaultProvider) createLaunchTemplate(ctx context.Context, options *ami | |||
TagSpecifications: []*ec2.TagSpecification{ | |||
{ | |||
ResourceType: aws.String(ec2.ResourceTypeLaunchTemplate), | |||
Tags: utils.MergeTags(options.Tags, map[string]string{v1beta1.TagManagedLaunchTemplate: options.ClusterName, v1beta1.LabelNodeClass: options.NodeClassName}), | |||
Tags: utils.MergeTags(options.Tags, map[string]string{ | |||
v1beta1.EksClusterNameAnnotationKey: options.ClusterName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this adds the eks cluster annotation tag on now, is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, according to @mikestef9, it should be added to all resources Karpenter creates.
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Pull Request Test Coverage Report for Build 9553195221Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #N/A
Description
Update to use EKS controller tagging standards
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.