Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add troubleshooting note on SGPP and max-pods #6380

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jun 18, 2024

Fixes #N/A

Description
Adds a note in the troubleshooting guide on Security Groups Per Pod and the impact on max pods.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner June 18, 2024 17:41
@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label Jun 18, 2024
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit f00363f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6675bdea92484c00088c59b2
😎 Deploy Preview https://deploy-preview-6380--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmdeal
Copy link
Contributor Author

jmdeal commented Jun 18, 2024

Blocking until wording is approved, then I'll copy over to the other doc versions

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9569692198

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.467%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9556663188: -0.01%
Covered Lines: 5550
Relevant Lines: 6730

💛 - Coveralls

website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9570272031

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.467%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9569831660: -0.01%
Covered Lines: 5550
Relevant Lines: 6730

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9587671338

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.467%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9569831660: -0.01%
Covered Lines: 5550
Relevant Lines: 6730

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9617680379

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.481%

Totals Coverage Status
Change from base Build 9569831660: 0.0%
Covered Lines: 5551
Relevant Lines: 6730

💛 - Coveralls

@jmdeal jmdeal removed the blocked Unable to make progress due to some dependency label Jun 21, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) June 21, 2024 17:54
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9617749237

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.481%

Totals Coverage Status
Change from base Build 9601098644: 0.01%
Covered Lines: 5551
Relevant Lines: 6730

💛 - Coveralls

@jmdeal jmdeal merged commit c384c3c into aws:main Jun 21, 2024
18 checks passed
@jmdeal jmdeal deleted the docs/troubleshoot-sgp branch August 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants