Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update GetSupportedNodeClasses to return []status.Object #6414

Merged
merged 1 commit into from
Jul 8, 2024
Merged

chore: Update GetSupportedNodeClasses to return []status.Object #6414

merged 1 commit into from
Jul 8, 2024

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented Jun 26, 2024 •
edited
Loading

Fixes #N/A

Description
This PR adds a change to return []status.object from GetSupportedNodeClasses

How was this change tested?
Tested on local cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner June 26, 2024 22:27
@jigisha620 jigisha620 requested a review from rschalo June 26, 2024 22:27
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit aaca676
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668c29fb00673e0008d70d59

@jigisha620 jigisha620 changed the title WIP: Update GetSupportedNodeClasses to return []status.Object chore: Update GetSupportedNodeClasses to return []status.Object Jun 28, 2024
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9719173984

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 78.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 4 0.0%
pkg/fake/cloudprovider.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/cloudprovider.go 1 73.28%
pkg/fake/cloudprovider.go 1 0.0%
Totals Coverage Status
Change from base Build 9717381388: -0.04%
Covered Lines: 5786
Relevant Lines: 7390
💛 - Coveralls

jonathan-innis
jonathan-innis reviewed Jun 29, 2024
View reviewed changes
pkg/cloudprovider/cloudprovider.go Outdated Show resolved Hide resolved
pkg/fake/cloudprovider.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9753011005

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 78.434%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 2 0.0%
pkg/fake/cloudprovider.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/cloudprovider.go 1 73.88%
pkg/fake/cloudprovider.go 1 0.0%
Totals Coverage Status
Change from base Build 9752794287: 0.01%
Covered Lines: 5801
Relevant Lines: 7396
💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

jigisha620
jigisha620 commented Jul 4, 2024
View reviewed changes
Copy link
Contributor Author

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-55bad29e4e2799b55fc93b0b1889d81086790cfb.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-55bad29e4e2799b55fc93b0b1889d81086790cfb" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9813097959

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 78.749%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 2 0.0%
pkg/fake/cloudprovider.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/cloudprovider.go 1 73.88%
pkg/fake/cloudprovider.go 1 0.0%
Totals Coverage Status
Change from base Build 9786416051: 0.0%
Covered Lines: 5940
Relevant Lines: 7543
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9813218711

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 78.749%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 2 0.0%
pkg/fake/cloudprovider.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/cloudprovider.go 1 73.88%
pkg/fake/cloudprovider.go 1 0.0%
Totals Coverage Status
Change from base Build 9786416051: 0.0%
Covered Lines: 5940
Relevant Lines: 7543
💛 - Coveralls

njtran
njtran approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jigisha620
jigisha620 commented Jul 5, 2024
View reviewed changes
Copy link
Contributor Author

@jigisha620 jigisha620 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jigisha620
jigisha620 commented Jul 5, 2024
View reviewed changes
Copy link
Contributor Author

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-04165e819237b08d29fefa4529ad2eea7873ce87.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-04165e819237b08d29fefa4529ad2eea7873ce87" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9844631660

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 78.842%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 2 0.0%
pkg/fake/cloudprovider.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/cloudprovider.go 1 73.88%
pkg/fake/cloudprovider.go 1 0.0%
Totals Coverage Status
Change from base Build 9844518117: 0.0%
Covered Lines: 5951
Relevant Lines: 7548
💛 - Coveralls

jigisha620
jigisha620 commented Jul 8, 2024
View reviewed changes
Copy link
Contributor Author

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-aaca67639c645f6b01aef089afe44b8b17b9a99e.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-aaca67639c645f6b01aef089afe44b8b17b9a99e" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran
njtran approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jigisha620 jigisha620 merged commit 70fdfa4 into aws:main Jul 8, 2024
24 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn left review comments

@njtran njtran njtran approved these changes

@jonathan-innis jonathan-innis jonathan-innis left review comments

@rschalo rschalo Awaiting requested review from rschalo rschalo is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jigisha620 @coveralls @ellistarn @njtran @jonathan-innis