Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix time out in scale tests #6451

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Deprovisioning scale tests were timing out since we merged the "Wait for instance termination PR". This was happening because the disruption budget of 10% would not allow all the nodes to be gone together thereby increasing the time taken for nodes to be deleted. To fix this, the budget has been increased to 70% in this PR.

How was this change tested?
Ran these tests on local cluster.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 4, 2024 22:40
@jigisha620 jigisha620 requested a review from njtran July 4, 2024 22:40
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8076ccd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66901dc6c7fac20008b7f179

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9800554041

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.762%

Totals Coverage Status
Change from base Build 9786416051: 0.01%
Covered Lines: 5941
Relevant Lines: 7543

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9896267586

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.765%

Totals Coverage Status
Change from base Build 9896231219: 0.0%
Covered Lines: 5612
Relevant Lines: 7125

💛 - Coveralls

@jigisha620 jigisha620 force-pushed the fix-scale-tests branch 2 times, most recently from 355af82 to ac2643f Compare July 9, 2024 22:31
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit a5d495e into aws:main Jul 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants