Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Karpenter to use v1 APIs #1389 #6454

Closed
wants to merge 8 commits into from

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jul 5, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 891c4a7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/669068bdfb6eaf0008b27821
😎 Deploy Preview https://deploy-preview-6454--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 9811889057

Details

  • 306 of 329 (93.01%) changed or added relevant lines in 39 files are covered.
  • 192 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.0%) to 79.756%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 32 33 96.97%
pkg/cloudprovider/events/events.go 1 2 50.0%
pkg/controllers/interruption/events/events.go 5 6 83.33%
pkg/controllers/nodeclass/hash/controller.go 10 11 90.91%
pkg/controllers/nodeclass/status/controller.go 3 4 75.0%
pkg/controllers/nodeclaim/tagging/controller.go 7 9 77.78%
pkg/providers/launchtemplate/launchtemplate.go 12 14 85.71%
pkg/controllers/nodeclass/termination/controller.go 6 9 66.67%
pkg/providers/amifamily/resolver.go 16 19 84.21%
pkg/fake/cloudprovider.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1beta1/ec2nodeclass_status.go 9 0.0%
pkg/apis/v1beta1/ec2nodeclass.go 13 35.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 170 20.24%
Totals Coverage Status
Change from base Build 9786416051: 1.0%
Covered Lines: 6016
Relevant Lines: 7543

💛 - Coveralls

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-318d924db834e193e8bcc9169928bd0f79327d5b.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-318d924db834e193e8bcc9169928bd0f79327d5b" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9886930806

Details

  • 345 of 376 (91.76%) changed or added relevant lines in 41 files are covered.
  • 197 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.0%) to 80.058%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/events/events.go 1 2 50.0%
pkg/controllers/interruption/events/events.go 5 6 83.33%
pkg/controllers/nodeclass/hash/controller.go 10 11 90.91%
pkg/controllers/nodeclass/status/ami.go 5 6 83.33%
pkg/controllers/nodeclass/status/controller.go 3 4 75.0%
pkg/controllers/nodeclaim/tagging/controller.go 7 9 77.78%
pkg/providers/launchtemplate/launchtemplate.go 12 14 85.71%
pkg/utils/utils.go 25 27 92.59%
pkg/controllers/nodeclass/termination/controller.go 6 9 66.67%
pkg/providers/amifamily/resolver.go 16 19 84.21%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1beta1/ec2nodeclass.go 13 35.0%
pkg/apis/v1beta1/ec2nodeclass_status.go 14 0.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 170 20.24%
Totals Coverage Status
Change from base Build 9886167627: 1.0%
Covered Lines: 6074
Relevant Lines: 7587

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-32482ac6ba58d5c5dd8b60da3c08b48ee01973fe.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-32482ac6ba58d5c5dd8b60da3c08b48ee01973fe" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jmdeal jmdeal marked this pull request as ready for review July 11, 2024 15:51
@jmdeal jmdeal requested a review from a team as a code owner July 11, 2024 15:51
@jmdeal jmdeal requested a review from njtran July 11, 2024 15:51
@engedaam engedaam closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants