Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update preview for getting started guide for MNG and Fargate #6523

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • The preview docs should reference the main branch as the is the branch where permission and API changes are pushed
  • These changes impact the MNG and Fargate steps

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner July 16, 2024 16:57
@engedaam engedaam requested a review from rschalo July 16, 2024 16:58
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e1ea179
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6696a69959bfba0008b837d6
😎 Deploy Preview https://deploy-preview-6523--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9961007379

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.086%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.6%
Totals Coverage Status
Change from base Build 9960877856: -0.01%
Covered Lines: 5933
Relevant Lines: 7502

💛 - Coveralls

@engedaam engedaam enabled auto-merge (squash) July 16, 2024 17:04
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 9f5a7d9 into aws:main Jul 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants