Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reconfigure metrics that are duplicated #6524

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented Jul 16, 2024

Fixes #N/A

Description
Reconfigured Karpenter metrics that are duplicated (workqueue metrics, renames of existing metrics).

  1. Changed karpenter_received_messages to karpenter_received_messages_total (this abides by Prometheus naming convention)
  2. Changed karpenter_deleted_messages to karpenter_deleted_messages_total (this abides by Prometheus naming convention)
  3. Dropped the karpenter_interruption_actions_performed_total
  4. Changed karpenter_interruption_message_latency_seconds to karpenter_interruption_message_queue_duration_seconds

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 16, 2024 20:20
@jigisha620 jigisha620 requested a review from engedaam July 16, 2024 20:20
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit af0d1f1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/669ad7352bdcf000088b7bab

@coveralls
Copy link

coveralls commented Jul 16, 2024

Pull Request Test Coverage Report for Build 10014419256

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 79.118%

Totals Coverage Status
Change from base Build 10011427993: -0.003%
Covered Lines: 5937
Relevant Lines: 7504

💛 - Coveralls

@engedaam
Copy link
Contributor

Will this PR include the change from upstream? Also we should include the changes to the docs in this PR

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 06d0c70 into aws:main Jul 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants