fix: ami family conversion #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jmdeal
force-pushed
the
fix/amifamily-conversion
branch
from
bd13a5a
to
689d937
Compare
Fixes the following issues with AMI conversion: - Fail closed when the AMI family we're convering from is Ubuntu - Don't create an alias when the AMI family is non-custom but selector terms are specified
jmdeal
force-pushed
the
fix/amifamily-conversion
branch
from
689d937
to
c8e9c26
Compare
njtran
previously approved these changes
Jul 16, 2024
Pull Request Test Coverage Report for Build 9963924851Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues with AMI conversion:
Fixes #N/A
Description
This PR fixes two issues with the conversion webhooks for AMI family and selector terms:
How was this change tested?
make testDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.