chore: upgrade go mod and update tests #6614

njtran · 2024-07-31T01:48:30Z

Fixes #N/A

Description
This updates the go mod for upstream karpenter to use the latest to kubernetes-sigs/karpenter@a3ce73e

How was this change tested?
Here and locally

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-07-31T01:48:44Z

✅ Deploy Preview for karpenter-docs-prod ready!

Name	Link
🔨 Latest commit	`0df3a5d`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66abb021821c950009e9d87e
😎 Deploy Preview	https://deploy-preview-6614--karpenter-docs-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

njtran

/karpenter snapshot

github-actions · 2024-07-31T01:52:47Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d4f7fbae478098ab25dcf966672bfa5b06a34a3d.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d4f7fbae478098ab25dcf966672bfa5b06a34a3d" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

coveralls · 2024-07-31T01:53:23Z

Pull Request Test Coverage Report for Build 10201643156

Details

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 79.27%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	91.67%
pkg/fake/utils.go	2	94.56%

Totals
Change from base Build 10171180634:	-0.04%
Covered Lines:	5973
Relevant Lines:	7535

💛 - Coveralls

njtran

/karpenter snapshot

github-actions · 2024-07-31T03:27:24Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-eb35b5f15a4f470164dd7a2a73b4bfbdf22bd047.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-eb35b5f15a4f470164dd7a2a73b4bfbdf22bd047" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

Do we have additional integration tests that we need to add now for specifying consolidateAfter with the WhenUnderutilized consolidation policy?

test/suites/integration/validation_test.go

njtran

/karpenter snapshot

github-actions · 2024-07-31T15:27:58Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-9ec36fb062187e444b251d9b8eb9128681c3bc92.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-9ec36fb062187e444b251d9b8eb9128681c3bc92" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/karpenter snapshot

github-actions · 2024-07-31T15:39:47Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-dc8bf8c81c8186e8891093b677b0d780f6ab7ddd.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-dc8bf8c81c8186e8891093b677b0d780f6ab7ddd" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/karpenter snapshot

github-actions · 2024-07-31T17:41:03Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-77aaba76c8c655f3357439c016ed53414e20a418.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-77aaba76c8c655f3357439c016ed53414e20a418" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/karpenter snapshot

github-actions · 2024-08-01T00:48:01Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-87cabe19e7dafb6b19c19833dfb443b1704adc66.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-87cabe19e7dafb6b19c19833dfb443b1704adc66" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

test/pkg/environment/common/environment.go

website/content/en/preview/tasks/managing-amis.md

website/content/en/preview/concepts/disruption.md

website/content/en/preview/concepts/nodepools.md

jonathan-innis

LGTM 🚀

njtran added 2 commits July 30, 2024 18:43

chore: upgrade go mod and update tests

a203cee

update to latest

d4f7fba

njtran requested a review from a team as a code owner July 31, 2024 01:48

njtran requested a review from tzneal July 31, 2024 01:48

njtran commented Jul 31, 2024

View reviewed changes

njtran enabled auto-merge (squash) July 31, 2024 02:41

update consolidateAfters

eb35b5f

njtran commented Jul 31, 2024

View reviewed changes

jonathan-innis previously approved these changes Jul 31, 2024

View reviewed changes

test/suites/integration/validation_test.go Outdated Show resolved Hide resolved

test/suites/integration/validation_test.go Outdated Show resolved Hide resolved

AndrewSirenko mentioned this pull request Jul 31, 2024

test: Ensure no 6+ minute delays for disrupted stateful workloads #6484

Merged

3 tasks

fix emptiness

65ad122

njtran dismissed jonathan-innis’s stale review via 65ad122 July 31, 2024 15:10

fix operatorpkg bug

9ec36fb

njtran commented Jul 31, 2024

View reviewed changes

fix status

dc8bf8c

njtran commented Jul 31, 2024

View reviewed changes

fix crd validation

77aaba7

njtran commented Jul 31, 2024

View reviewed changes

njtran added 2 commits July 31, 2024 16:50

fix taint indexer

08c2e90

update consolidationPolicy

87cabe1

njtran commented Aug 1, 2024

View reviewed changes

jonathan-innis reviewed Aug 1, 2024

View reviewed changes

respond to comments

0df3a5d

jonathan-innis approved these changes Aug 1, 2024

View reviewed changes

njtran merged commit bd98ea3 into aws:main Aug 1, 2024
16 checks passed

njtran deleted the consolidatione2es branch August 1, 2024 16:33

njtran restored the consolidatione2es branch August 1, 2024 16:35

njtran deleted the consolidatione2es branch August 1, 2024 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade go mod and update tests #6614

chore: upgrade go mod and update tests #6614

njtran commented Jul 31, 2024 •

edited

Loading

netlify bot commented Jul 31, 2024 •

edited

Loading

njtran left a comment

github-actions bot commented Jul 31, 2024

coveralls commented Jul 31, 2024 •

edited

Loading

njtran left a comment

github-actions bot commented Jul 31, 2024

jonathan-innis left a comment

njtran left a comment

github-actions bot commented Jul 31, 2024

njtran left a comment

github-actions bot commented Jul 31, 2024

njtran left a comment

github-actions bot commented Jul 31, 2024

njtran left a comment

github-actions bot commented Aug 1, 2024

jonathan-innis left a comment

chore: upgrade go mod and update tests #6614

chore: upgrade go mod and update tests #6614

Conversation

njtran commented Jul 31, 2024 • edited Loading

netlify bot commented Jul 31, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod ready!

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

coveralls commented Jul 31, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10201643156

Details

💛 - Coveralls

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 1, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

njtran commented Jul 31, 2024 •

edited

Loading

netlify bot commented Jul 31, 2024 •

edited

Loading

coveralls commented Jul 31, 2024 •

edited

Loading