fix: Update AMIFamily for non-AL2023 AMIs #6638

engedaam · 2024-08-02T17:28:16Z

Fixes #N/A

Description

Update AMIFamily for non-AL2023 versions

How was this change tested?

/karpenter snapshot

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

engedaam

/karpenter snapshot

netlify · 2024-08-02T17:29:00Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`2dd27c2`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ad2442bfadeb00082d61eb

github-actions · 2024-08-02T17:32:05Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-2da8d656638e94858403c22b61e9ef1768668ad9.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-2da8d656638e94858403c22b61e9ef1768668ad9" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

coveralls · 2024-08-02T17:33:01Z

Pull Request Test Coverage Report for Build 10220269111

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.267%

Totals
Change from base Build 10217681310:	0.0%
Covered Lines:	5972
Relevant Lines:	7534

💛 - Coveralls

engedaam

/karpenter snapshot

github-actions · 2024-08-02T17:37:42Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-1e4fa997555a3eb65c676b640bc8bb61d990056d.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-1e4fa997555a3eb65c676b640bc8bb61d990056d" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/LGTM

Thanks for picking this up!!

test/suites/ami/suite_test.go

engedaam

/karpenter snapshot

test/pkg/environment/aws/environment.go

github-actions · 2024-08-02T18:04:26Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-e175de66c477113fe1cc7e55755edfc974af8069.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-e175de66c477113fe1cc7e55755edfc974af8069" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-08-02T18:20:09Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-af48fe6691f06428a455b4102b1d813aadb66fc2.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-af48fe6691f06428a455b4102b1d813aadb66fc2" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-08-02T18:29:56Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-2dd27c26e73f53bbf2e7743ac75bf8338e507d7a.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-2dd27c26e73f53bbf2e7743ac75bf8338e507d7a" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

LGTM 🚀

engedaam requested a review from a team as a code owner August 2, 2024 17:28

engedaam requested a review from jonathan-innis August 2, 2024 17:28

engedaam commented Aug 2, 2024

View reviewed changes

engedaam force-pushed the fix-e2es branch from 2da8d65 to 1e4fa99 Compare August 2, 2024 17:31

engedaam commented Aug 2, 2024

View reviewed changes

njtran previously approved these changes Aug 2, 2024

View reviewed changes

jonathan-innis reviewed Aug 2, 2024

View reviewed changes

test/suites/ami/suite_test.go Outdated Show resolved Hide resolved

Remove default AMIFamily

4be3340

engedaam dismissed njtran’s stale review via 4be3340 August 2, 2024 18:00

engedaam force-pushed the fix-e2es branch from 1e4fa99 to 4be3340 Compare August 2, 2024 18:00

engedaam commented Aug 2, 2024

View reviewed changes

jonathan-innis reviewed Aug 2, 2024

View reviewed changes

test/pkg/environment/aws/environment.go Show resolved Hide resolved

engedaam force-pushed the fix-e2es branch from e175de6 to af48fe6 Compare August 2, 2024 18:10

engedaam commented Aug 2, 2024

View reviewed changes

engedaam force-pushed the fix-e2es branch from af48fe6 to d2e2a2a Compare August 2, 2024 18:22

Merge branch 'main' into fix-e2es

2dd27c2

engedaam force-pushed the fix-e2es branch from d2e2a2a to 2dd27c2 Compare August 2, 2024 18:24

engedaam commented Aug 2, 2024

View reviewed changes

jonathan-innis approved these changes Aug 2, 2024

View reviewed changes

jonathan-innis enabled auto-merge (squash) August 2, 2024 18:31

jonathan-innis disabled auto-merge August 2, 2024 18:31

engedaam enabled auto-merge (squash) August 2, 2024 19:46

engedaam merged commit 63de7bf into aws:main Aug 2, 2024
23 of 32 checks passed

engedaam deleted the fix-e2es branch August 2, 2024 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update AMIFamily for non-AL2023 AMIs #6638

fix: Update AMIFamily for non-AL2023 AMIs #6638

engedaam commented Aug 2, 2024

engedaam left a comment

netlify bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024

coveralls commented Aug 2, 2024 •

edited

Loading

engedaam left a comment

github-actions bot commented Aug 2, 2024

njtran left a comment

engedaam left a comment

github-actions bot commented Aug 2, 2024

engedaam left a comment

github-actions bot commented Aug 2, 2024

engedaam left a comment

github-actions bot commented Aug 2, 2024

jonathan-innis left a comment

fix: Update AMIFamily for non-AL2023 AMIs #6638

fix: Update AMIFamily for non-AL2023 AMIs #6638

Conversation

engedaam commented Aug 2, 2024

engedaam left a comment

Choose a reason for hiding this comment

netlify bot commented Aug 2, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

github-actions bot commented Aug 2, 2024

coveralls commented Aug 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10220269111

Details

💛 - Coveralls

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

njtran left a comment

Choose a reason for hiding this comment

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

netlify bot commented Aug 2, 2024 •

edited

Loading

coveralls commented Aug 2, 2024 •

edited

Loading