Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make image configurable #6716

Merged
merged 2 commits into from
Aug 12, 2024
Merged

chore: make image configurable #6716

merged 2 commits into from
Aug 12, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Aug 12, 2024

Fixes #6701

Description
Makes the post-install hook version configurable

How was this change tested?
make apply

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner August 12, 2024 19:12
@njtran njtran requested a review from jmdeal August 12, 2024 19:12
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 39b1673
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ba658498bcaf00086adacb

@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10358302045

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 79.307%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10357709856: 0.01%
Covered Lines: 5998
Relevant Lines: 7563

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 74458b7 into aws:main Aug 12, 2024
16 checks passed
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 12, 2024
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 12, 2024
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 12, 2024
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Aug 12, 2024
jmdeal pushed a commit to jmdeal/karpenter-provider-aws that referenced this pull request Aug 12, 2024
jmdeal pushed a commit to jmdeal/karpenter-provider-aws that referenced this pull request Aug 12, 2024
@jmdeal jmdeal mentioned this pull request Aug 12, 2024
3 tasks
jmdeal pushed a commit to jmdeal/karpenter-provider-aws that referenced this pull request Aug 12, 2024
jmdeal pushed a commit that referenced this pull request Aug 12, 2024
jmdeal pushed a commit that referenced this pull request Aug 12, 2024
engedaam pushed a commit that referenced this pull request Aug 12, 2024
jmdeal pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart: Allow overriding container image url for post-install-job
3 participants