Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example link to example NodePools #6811

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

kriths
Copy link
Contributor

@kriths kriths commented Aug 20, 2024

Fixes #N/A

Description
The current docs still link to examples in a folder v1beta1 that doesn't exist anymore. Changed the link to the correct path v1.

I searched for v1beta1 in the website folder to find other occurrences and it's still often used in examples. That might be worth checking for consistency's sake but shouldn't cause issues.

p.s. congrats on the big release!

How was this change tested?
Clicked the links :^)

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kriths kriths requested a review from a team as a code owner August 20, 2024 19:23
@kriths kriths requested a review from tzneal August 20, 2024 19:23
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 34bae89
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c4ed309ed095000845b49d
😎 Deploy Preview https://deploy-preview-6811--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10477900047

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.264%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10461120222: -0.01%
Covered Lines: 5921
Relevant Lines: 7470

💛 - Coveralls

@engedaam engedaam merged commit add3933 into aws:main Aug 20, 2024
16 checks passed
@kriths kriths deleted the docs/fix-node-pool-url branch August 21, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants