Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove RBAC permissions for node lease garbage collection #6812

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
We intend to drop the node lease garbage collection controller - kubernetes-sigs/karpenter#1586
This PR removes the RBAC permissions for interacting with leases.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner August 20, 2024 21:26
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7627e06
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c6641770e1c50007ce1763

@coveralls
Copy link

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10498139074

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.311%

Totals Coverage Status
Change from base Build 10497921621: 0.0%
Covered Lines: 5938
Relevant Lines: 7487

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Aug 21, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 095c7e3 into aws:main Aug 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants