Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable copyloopvar in linter #6830

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Aug 21, 2024

Fixes #N/A

Description

Replace exportloopref with copyloopvar (see https://go.dev/blog/loopvar-preview for more detail)

cd . && golangci-lint run 
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner August 21, 2024 22:14
@jonathan-innis jonathan-innis enabled auto-merge (squash) August 21, 2024 22:15
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8e8a082
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c6686a1b010f00085ea249

@jonathan-innis jonathan-innis changed the title ci: Enable copyloopvar in linter ci: Enable copyloopvar in linter Aug 21, 2024
@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 10498350720

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.311%

Totals Coverage Status
Change from base Build 10497921621: 0.0%
Covered Lines: 5938
Relevant Lines: 7487

💛 - Coveralls

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit cf67d5b into aws:main Aug 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants