Fix: add log path options for log paths to deployment #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
mariuskimmina
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
We were about to open the same PR, we tested this exact change on one of our test clusters and it seems to work.
Linking to the issue: kubernetes-sigs/karpenter#1572
Pull Request Test Coverage Report for Build 10530899211Details
💛 - Coveralls |
| {{- end }} | ||
| {{- with .Values.logOutputPaths }} | ||
| - name: LOG_OUTPUT_PATHS | ||
| value: "{{ . }}" |
There was a problem hiding this comment.
Does this work? Since it's an array, don't we need some helm magic to convert this into a comma-delimited list?
There was a problem hiding this comment.
Yes, it works. I believe that happens here:
|
@rschalo could you provide some context on why this PR got closed? |
|
Fix implemented in a different PR: #6875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kubernetes-sigs/karpenter#1572
Description
Bug fix for not referencing log output paths.
How was this change tested?
make test
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.