feat: drift instance types that no longer exist #7223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 11352410002Details
💛 - Coveralls |
| if !found { | ||
| return "", fmt.Errorf(`finding node instance type "%s"`, nodeClaim.Labels[corev1.LabelInstanceTypeStable]) | ||
| log.FromContext(ctx).V(1).Info(fmt.Sprintf("failed to find node instance type %q, continuing to drift", nodeClaim.Labels[corev1.LabelInstanceTypeStable])) |
There was a problem hiding this comment.
This seems like it might be generally applicable to all providers. Why just have this in the AWS provider?
There was a problem hiding this comment.
I imagine that different providers might have different ways to reason about instance type deprecations. I wouldn't want to be overhanded and assume we know how it should work for everyone
|
closing in favor of refactoring this generally into the upstream package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Makes sure that an instance type that no longer is returned in ec2 describe instance types, but may have an existing node with that instance type can still drift. Previously this would just error, resulting in users having to delete the instances themselves.
How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.