Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interruption-handling.md #7552

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update interruption-handling.md #7552

merged 1 commit into from
Jan 7, 2025

Conversation

paikend
Copy link
Contributor

@paikend paikend commented Dec 23, 2024

Improve readability

feat: Improve documentation readability by removing unnecessary backticks

Description

  • Remove unnecessary backticks(`) from IAM policy and EventBridge examples
  • Improve formatting and structure of security implications section
  • Keep original content intact while enhancing readability
  • No functional changes
    How was this change tested?
  • Ensured backtick removal doesn't impact code functionality

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@paikend
Update interruption-handling.md
62ad799 
Improve readability
@paikend paikend requested a review from a team as a code owner December 23, 2024 10:16
@paikend paikend requested a review from jmdeal December 23, 2024 10:16
@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 62ad799
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6769389196fb7500080f8821
😎 Deploy Preview https://deploy-preview-7552--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vacant2333
Copy link
Contributor

@jmdeal can u help him to review this pr?

engedaam
engedaam approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) January 7, 2025 18:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12465154400

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.125%
Totals Coverage Status
Change from base Build 12402493920: 0.0%
Covered Lines: 5774
Relevant Lines: 8866
💛 - Coveralls

@engedaam engedaam merged commit 46e7424 into aws:main Jan 7, 2025
18 checks passed
@paikend paikend deleted the patch-1 branch January 8, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vacant2333 Vacant2333 Vacant2333 approved these changes

@engedaam engedaam engedaam approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paikend @Vacant2333 @coveralls @engedaam