Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packets are gso'ed only if their size match the mtu #2212

Closed
pjalaber opened this issue May 16, 2024 · 2 comments
Closed

Packets are gso'ed only if their size match the mtu #2212

pjalaber opened this issue May 16, 2024 · 2 comments
Labels
question Further information is requested

Comments

@pjalaber
Copy link

Problem:

At first this test prevents building a gso train of packets if they are smaller than the mtu:

A similar issue has been recently fixed in Quinn:
quinn-rs/quinn#1837

Solution:

Lower the restriction on the mtu size and try to build a train of packets of smaller size.

Requirements / Acceptance Criteria:

Out of scope:

@camshaft
Copy link
Contributor

Generally packets are assembled to fit the max datagram size. So this logic would only apply to the final tail packet. Also keep in mind we have a burst rate of 10 packets so GSO should usually be under 15,000 bytes on public Internet links.

As such, I'm inclined to say it's fine as is.

@WesleyRosenblum WesleyRosenblum added the question Further information is requested label May 16, 2024
@WesleyRosenblum
Copy link
Contributor

Closing, feel free to reopen if you have further questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants