Match GSO segment size to the first datagram, not the MTU #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
compact-gso
branch
6 times, most recently
from
e7c47c4
to
a1add92
Compare
|
On second thought, maybe judging whether a datagram fits into a certain segment size in advance of beginning packet assembly isn't so bad. We already have the logic to make a conservative estimate in |
Ralith
force-pushed
the
compact-gso
branch
2 times, most recently
from
cbe6295
to
ce7f2f3
Compare
|
This is now feature-complete, but still needs testing. |
Ralith
force-pushed
the
compact-gso
branch
3 times, most recently
from
60c8054
to
28360a3
Compare
|
Went ahead and banged out the tests, finding and fixing a number of bugs in the process. |
djc
reviewed
Apr 29, 2024
Ralith
force-pushed
the
datagram-cleanup
branch
from
fae273a
to
79246f5
Compare
Ralith
force-pushed
the
compact-gso
branch
4 times, most recently
from
98b9664
to
733d798
Compare
djc
approved these changes
May 1, 2024
|
Good stuff! |
Ralith
force-pushed
the
compact-gso
branch
2 times, most recently
from
37a5fd9
to
aee7545
Compare
Reduces the amount of padding required when sending homogeneously sized non-fragmentable data like application datagrams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1832.
Still working onhow to handle the case where a datagram is queued but won't fit with the current segment size. We need to either detect this in advance and finish the GSO batch before beginning another packet, or gracefully abandon packet assembly after failing to fit any frames.Currently leaning towards the latter.This will need careful testing.Also still TODO: End the GSO batch early if the amount of padding in the current packet would be excessive.