Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch providers to not use opaque types #1821

Merged
merged 1 commit into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. Switch providers to not use opaque types

    The Rust compiler deals poorly with the signature of our providers,
    leading to exponential compile times with additional providers. In one
    real-world case this patch changes `cargo check` compile times from 6
    minutes to 20 seconds, which is a significant delta. The tradeoff with
    the current compiler is somewhat more verbose error messages, but given
    the potentially massive wins in compile time for users of this crate
    that seems worth it.
    Mark-Simulacrum committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    acc099e View commit details
    Browse the repository at this point in the history